GoKawiilI'm tired boss. I'm tired of reviewing one, two, three thousand line PRs because some agent was able to "one shot the whole issue." Small PRs were never asked for because they're easier to write, it's always been for the benefit of the reviewer. AI is such a boon to the industry, but it's becoming such a liability for reviewers and maintainers. Maybe I'm just an old man yelling at the clouds, but please, stop sending me huge PRs.
I have heard on multiple occasions recently the argument that "it won't work without the whole change" or "the code will do nothing if we don't put in the entire diff," well, yeah? Good? The point of small PRs is not necessarily to have small, individual, finished products. It's to have small, digestable, reviewable, understandable pieces of work. I have no data for this, so I will wildly speculate, that the time it takes to fully comprehend a piece of code increases exponentially with the number of lines the code covers. Taking up exponentially more of my time because you wanted to ship a full feature does not spark joy.
While we're at it, I don't need 50 line comments. Sure, document functions, give me jsdoc, rustdoc, javadoc, all of that good stuff. Absolutely do not give me 5 lines of comments on why a variable is named is_logged_in . If your variable is named well, 9 times out of 10 I'll understand what it does. If your variable is not named well and you need a comment, name your variable better.
Finally, for you AI maximalists that say "just use AI to grok (not grok) it bro," you're wasting your tokens reingesting code that was already made by an AI. "I use a different model for reviews though," okay, great, why did you put it up for a human review at all then? Perhaps, you could have your precious AI separate it for us mere mortals and then review it after we've had our turn?
Look -- AI is a great tool, it really helps things move faster and can make code better, but when React came out we didn't accept larger PRs because "React is faster to write and easier to read," so why are we doing it now?
Addendum: are you just making giant PRs so I give up halfway through and approve it? If so, well played. Well. Played.